Messages in this thread | | | From | Kurachkin Michail <> | Subject | RE: TDM bus support in Linux Kernel [PATCH] | Date | Wed, 30 Jan 2013 12:37:25 +0000 |
| |
Hi Greg,
I followed your recommendations and created a diff using Linux 3.8-rc5 sources. Please review it and give your comments.
Regrads, Michail ________________________________________ From: Greg Kroah-Hartman [gregkh@linuxfoundation.org] Sent: Thursday, November 29, 2012 1:38 To: Kurachkin Michail Cc: linux-kernel@vger.kernel.org; Kuten Ivan; Josh Triplett Subject: Re: TDM bus support in Linux Kernel
On Mon, Nov 19, 2012 at 11:00:12AM +0000, Kurachkin Michail wrote: > Hi Greg, > > During the work on developing VoIP network router I designed TDM bus subsystem and wrote SLIC driver for si3226x. This code was developed for the commercial project, and now I am willing to release it under GPL. > Please review my sources (or give me a clue on what to do next) and give some feedback on my work. > https://github.com/stelhs/slic_tdm.git
It's really hard to review a random git tree somewhere, and having it in this form doesn't make it easy to add to the kernel tree itself.
So, could you take your git tree and convert it to a patch (or patches) to be applied to the kernel.org tree and send it in email so we can see what it looks like that way?
I'd recommend putting everything under drivers/staging/ for now, to make it easier to accept at the moment, and it makes it easier to clean up and fix up any issues in-kernel, instead of having to keep huge patches outside of the tree.
Take a look at the file, Documentation/SubmittingPatches for how to create a patch and what I need in order for it to be able to be applied.
thanks,
greg k-h [unhandled content-type:application/octet-stream] | |