Messages in this thread | | | Subject | Re: [PATCH v2] Add 4 tracepoint events for vfs | From | Steven Rostedt <> | Date | Wed, 30 Jan 2013 07:30:18 -0500 |
| |
On Wed, 2013-01-30 at 14:35 +0800, chenggang wrote: > +#include <asm/ptrace.h> > + > +DECLARE_EVENT_CLASS(vfs_filerw_template, > + > + TP_PROTO(long long pos, unsigned long bytes, unsigned char *fname),
One last nit. Might want to make fname "const".
-- Steve
> + > + TP_ARGS(pos, bytes, fname), > + > + TP_STRUCT__entry( > + __field( long long, pos ) > + __field( unsigned long, bytes ) > + __string( fname, fname ) > + ), > + > + TP_fast_assign( > + __entry->pos = pos; > + __entry->bytes = bytes; > + __assign_str(fname, fname); > + ), > + > + TP_printk("Filename: %s Pos: %lld Bytes: %lu", > + __get_str(fname), __entry->pos, __entry->bytes) > +); > +
| |