lkml.org 
[lkml]   [2013]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 40/71] ARC: OProfile support
On 30/01/13 06:34, Vineet Gupta wrote:
> On Tuesday 29 January 2013 10:35 PM, James Hogan wrote:
>> Hi Vineet,
>>
>> You don't appear to define CONFIG_HW_PERF_EVENTS, so
>> include/linux/oprofile.h will presumably define oprofile_perf_init as
>> just a pr_info(...); return -ENODEV;
>>
>> Similarly drivers/oprofile/oprofile_perf.o doesn't seem to be being built.
>>
>> I'm probably missing something somewhere?
>
> Not much :-)
>
> oprofile_arch_init() failure causes oprofile to fall back to timer based PC only
> sampling - for coarse grained profiling. I'll soon be starting on integratign the
> hardware counter support to both oprofile/perf.

Okay cool. It's just slightly misleading for anybody copying the code
that it calls oprofile_perf_init which is known never to do anything
:-). Maybe it's worth adding a comment in there to clarify. If it's only
temporary I'm fine with it.

Reviewed-by: James Hogan <james.hogan@imgtec.com>

Cheers
James



\
 
 \ /
  Last update: 2013-01-30 12:43    [W:0.072 / U:2.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site