lkml.org 
[lkml]   [2013]   [Jan]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] dtc: fdtdump, properly handle multi-string properties
On 01/03/2013 04:32 PM, Pantelis Antoniou wrote:
> Device tree can store multiple strings in a single property.
> We didn't handle that case properly.
>
> Signed-off-by: Pantelis Antoniou <panto@antoniou-consulting.com>
> ---
> scripts/dtc/fdtdump.c | 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)

These need to be posted against the upstream dtc sources and to the dtc
maintainer Jon Loeliger.

Rob

>
> diff --git a/scripts/dtc/fdtdump.c b/scripts/dtc/fdtdump.c
> index 207a46d..d4fa6d7 100644
> --- a/scripts/dtc/fdtdump.c
> +++ b/scripts/dtc/fdtdump.c
> @@ -21,13 +21,23 @@ static void print_data(const char *data, int len)
> {
> int i;
> const char *p = data;
> + const char *s;
>
> /* no data, don't print */
> if (len == 0)
> return;
>
> if (util_is_printable_string(data, len)) {
> - printf(" = \"%s\"", (const char *)data);
> + printf(" = ");
> +
> + s = data;
> + do {
> + printf("\"%s\"", s);
> + s += strlen(s) + 1;
> + if (s < data + len)
> + printf(", ");
> + } while (s < data + len);
> +
> } else if ((len % 4) == 0) {
> printf(" = <");
> for (i = 0; i < len; i += 4)
>


\
 
 \ /
  Last update: 2013-01-04 01:01    [W:0.049 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site