lkml.org 
[lkml]   [2013]   [Jan]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] xfs: return -EINVAL instead of -EUCLEAN when mounting non-xfs
On Sun, Dec 30, 2012 at 02:16:50AM +0300, Sergei Trofimovich wrote:
> It fixes boot panic when trying to boot from btrfs filesystem.
> kernel tries to mount as xfs and gets fatal -EUCLEAN:
>
> [ 0.170000] VFS: Cannot open root device "ubda" or unknown-block(98,0): error -117
> [ 0.170000] Please append a correct "root=" boot option; here are the available partitions:
> [ 0.170000] 6200 1048576 ubda driver: uml-blkdev
> [ 0.170000] Kernel panic - not syncing: VFS: Unable to mount root fs on unknown-block(98,0)
>
> init/do_mounts.c expects only -EINVAL as 'retry another' option.
> Fixes regression introduced by commit 98021821a502db347bd9c7671beeee6e8ce07ea6

Looks reasonable, but think xfs_readsb should simply be changed to
turn all EFSCORRUPTED returns into EINVAL if loud is not set. The
place that changes the errno value would also be a perfect place to
comment why we are doing this in the code so that this knowledge doesn't
get lost.



\
 
 \ /
  Last update: 2013-01-03 20:01    [W:0.512 / U:0.188 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site