Messages in this thread | | | Date | Thu, 03 Jan 2013 09:41:53 -0800 | From | "H. Peter Anvin" <> | Subject | Re: [RFC PATCH 1/2] efi: Make 'efi_enabled' a function to query EFI facilities |
| |
On 01/03/2013 05:18 AM, Matt Fleming wrote: > > A machine's EFI facilities are naturally represented by a bitfield. >
Nitpick: what you have here is a bitmask, not a bitfield. This is good, because bitfields are generally frowned upon in a Linux kernel context, but you may want to revise the description.
Other than that, looks good to me.
Acked-by: H. Peter Anvin <hpa@linux.intel.com>
-hpa (who is still on vacation)
-- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf.
| |