Messages in this thread Patch in this message | | | Subject | [PATCH V2] checkpatch: prefer dev_<level>( to dev_printk(KERN_<LEVEL> | From | Joe Perches <> | Date | Thu, 03 Jan 2013 08:49:52 -0800 |
| |
Add YA check to printk style.
dev_<level> uses are functions and generate smaller object code than dev_printk(KERN_<LEVEL>.
Signed-off-by: Joe Perches <joe@perches.com> --- V2: Remove unnecessary copy/paste logic from pr_<level> conversion above it.
scripts/checkpatch.pl | 9 +++++++++ 1 file changed, 9 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 9de3a69..9a1ae72 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2425,6 +2425,15 @@ sub process { "Prefer pr_warn(... to pr_warning(...\n" . $herecurr); } + if ($line =~ /\bdev_printk\s*\(\s*KERN_([A-Z]+)/) { + my $orig = $1; + my $level = lc($orig); + $level = "warn" if ($level eq "warning"); + $level = "dbg" if ($level eq "debug"); + WARN("PREFER_DEV_LEVEL", + "Prefer dev_$level(... to dev_printk(KERN_$orig, ...\n" . $herecurr); + } + # function brace can't be on same line, except for #defines of do while, # or if closed on same line if (($line=~/$Type\s*$Ident\(.*\).*\s{/) and
| |