lkml.org 
[lkml]   [2013]   [Jan]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[RFC PATCH 2/2] samsung-laptop: Disable on EFI hardware
    Date
    From: Matt Fleming <matt.fleming@intel.com>

    There have been reports of this driver causing Machine Check
    Exceptions on recent EFI-enabled Samsung laptops,

    https://bugzilla.kernel.org/show_bug.cgi?id=47121

    So disable it if booting from EFI since this driver relies on
    grovelling around in the BIOS memory map which isn't going to work.

    Cc: Corentin Chary <corentincj@iksaif.net>
    Cc: Matthew Garrett <mjg59@srcf.ucam.org>
    Cc: Steve Langasek <steve.langasek@canonical.com>
    Cc: platform-driver-x86@vger.kernel.org
    Signed-off-by: Matt Fleming <matt.fleming@intel.com>
    ---
    drivers/platform/x86/samsung-laptop.c | 3 +++
    1 file changed, 3 insertions(+)

    diff --git a/drivers/platform/x86/samsung-laptop.c b/drivers/platform/x86/samsung-laptop.c
    index dd90d15..a94c0ee 100644
    --- a/drivers/platform/x86/samsung-laptop.c
    +++ b/drivers/platform/x86/samsung-laptop.c
    @@ -1534,6 +1534,9 @@ static int __init samsung_init(void)
    struct samsung_laptop *samsung;
    int ret;

    + if (efi_enabled(EFI_BOOT))
    + return -ENODEV;
    +
    quirks = &samsung_unknown;
    if (!force && !dmi_check_system(samsung_dmi_table))
    return -ENODEV;
    --
    1.7.11.7


    \
     
     \ /
      Last update: 2013-01-03 15:01    [W:3.870 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site