lkml.org 
[lkml]   [2013]   [Jan]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86/apic: check FADT settings after enable x2apic

* Wang, Song-Bo (Stoney) <song-bo.wang@hp.com> wrote:

> [...] Due to this mode mismatch, with specific HW
> configurations, there will be intermittent lost interrupts,
> which could result in a hang or data loss.

That's the key piece of information that was missing - which
should be put into the changelog into a very prominent place.

> Logically, there is a mismatch because the kernel missed
> detection on HW configurations, and we should fix it, right?
> Do we need more detailed information?

No, the above sentence is more than enough and the fix looks
nice. Note that this sentence is more useful to users than the
rest of the changelog combined!

Thanks,

Ingo


\
 
 \ /
  Last update: 2013-01-29 10:21    [W:0.087 / U:0.312 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site