lkml.org 
[lkml]   [2013]   [Jan]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 9/9] devcg: propagate local changes down the hierarchy
On Tue, Jan 29, 2013 at 12:35:00PM -0800, Tejun Heo wrote:
> Generally looks good to me although I haven't really delved into the
> behavior (you're gonna be there for the fallouts, right?). Just some
> minor comments.

yes, I'll.

> > +static int propagate_behavior(struct dev_cgroup *devcg_root)
> > +{
> > + struct cgroup *root = devcg_root->css.cgroup, *pos;
> > + struct dev_cgroup *parent, *devcg, *tmp;
> > + int rc = 0;
> > + LIST_HEAD(pending);
> > +
> > + rcu_read_lock();
> > + cgroup_for_each_descendant_pre(pos, root) {
> > + devcg = cgroup_to_devcgroup(pos);
> > + if (is_devcg_online(devcg))
> > + list_add_tail(&devcg->propagate_pending, &pending);
> > + }
> > + rcu_read_unlock();
>
> I think it could be a good idea to factor out the above and document
> what's going on and why.

ok, will fix the missing bits based on your comments and resubmit.

--
Aristeu



\
 
 \ /
  Last update: 2013-01-29 22:22    [W:0.044 / U:1.504 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site