lkml.org 
[lkml]   [2013]   [Jan]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] sched: move scheduler sysctl bits into dedicated header file
On Tue, 29 Jan 2013 09:12:45 +0800
Li Zefan <lizefan@huawei.com> wrote:

> > -extern void sched_autogroup_create_attach(struct task_struct *p);
> > -extern void sched_autogroup_detach(struct task_struct *p);
> > -extern void sched_autogroup_fork(struct signal_struct *sig);
> > -extern void sched_autogroup_exit(struct signal_struct *sig);
> > -#ifdef CONFIG_PROC_FS
> > -extern void proc_sched_autogroup_show_task(struct task_struct *p, struct seq_file *m);
> > -extern int proc_sched_autogroup_set_nice(struct task_struct *p, int nice);
> > -#endif
> > -#else
> > -static inline void sched_autogroup_create_attach(struct task_struct *p) { }
> > -static inline void sched_autogroup_detach(struct task_struct *p) { }
> > -static inline void sched_autogroup_fork(struct signal_struct *sig) { }
> > -static inline void sched_autogroup_exit(struct signal_struct *sig) { }
> > -#endif
>
> but those function declarations have nothing to do with sysctl..
>
> > -
> > -#ifdef CONFIG_CFS_BANDWIDTH
> > -extern unsigned int sysctl_sched_cfs_bandwidth_slice;
> > -#endif
> > -
>


True, but they're all under the SCHED_AUTOGROUP config variable along
with:
extern unsigned int sysctl_sched_autogroup_enabled;

So I thought I'd keep them all grouped together.

I can move the prototypes back into sched.h but the whole reason for
doing this is to reduce the size of sched.

Guess I'll let Ingo make the call here.

Clark
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2013-01-29 19:41    [W:0.074 / U:0.264 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site