lkml.org 
[lkml]   [2013]   [Jan]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH v3 02/71] ARC: Build system: Makefiles, Kconfig, Linker script
On Tuesday 29 January 2013 12:14 AM, Sam Ravnborg wrote:
> On Mon, Jan 28, 2013 at 11:59:36AM +0530, Vineet Gupta wrote:
>> Hi Sam,
>>
>> On Thursday 24 January 2013 04:20 PM, Vineet Gupta wrote:
>>> Arnd in his review pointed out that arch Kconfig organisation has several
>>> deficiencies:
>>>
>>> * Build time entries for things which can be runtime extracted from DT
>>> (e.g. SDRAM size, core clk frequency..)
>>> * Not multi-platform-image-build friendly (choice .. endchoice constructs)
>>> * cpu variants support (750/770) is exclusive.
>>>
>>> The first 2 have been fixed in subsequent patches.
>>> Due to the nature of the 750 and 770, it is not possible to build for
>>> both together, w/o special runtime glue code which would hurt
>>> performance.
>>>
>>> Signed-off-by: Vineet Gupta <vgupta@synopsys.com>
>>> Cc: Arnd Bergmann <arnd@arndb.de>
>>> Cc: Sam Ravnborg <sam@ravnborg.org>
> Looks good - all former comments addressed, and nothing were jumping
> into my eyes now.
> Many existing architectures looks worse from the build stuff perspective...
>
> Acked-by: Sam Ravnborg <sam@ravnborg.org>
>
> Sam

Thx Sam. I have a following one liner change to the version you reviewed. Will it
be OK to add your ACK despite that or do I need to send the updated patch for you
to take a look again.

-Vineet

------------------------->8-----------------------
diff --git a/arch/arc/plat-arcfpga/Kconfig b/arch/arc/plat-arcfpga/Kconfig
index 3fecd6f..b41e786 100644
--- a/arch/arc/plat-arcfpga/Kconfig
+++ b/arch/arc/plat-arcfpga/Kconfig
@@ -8,6 +8,7 @@

menuconfig ARC_PLAT_FPGA_LEGACY
bool "\"Legacy\" ARC FPGA dev Boards"
+ select ISS_SMP_EXTN if SMP
help
Support for ARC development boards, provided by Synopsys.
These are based on FPGA or ISS. e.g.
@@ -19,7 +20,6 @@ if ARC_PLAT_FPGA_LEGACY

config ARC_BOARD_ANGEL4
bool "ARC Angel4"
- select ISS_SMP_EXTN if SMP
default y
help
ARC Angel4 FPGA Ref Platform (Xilinx Virtex Based)
------------------------->8-----------------------


\
 
 \ /
  Last update: 2013-01-29 15:21    [W:0.078 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site