Messages in this thread | | | Date | Tue, 29 Jan 2013 15:01:27 +0200 | From | "Kirill A. Shutemov" <> | Subject | Re: [PATCH, RFC 06/16] thp, mm: rewrite add_to_page_cache_locked() to support huge pages |
| |
Hillf Danton wrote: > On Mon, Jan 28, 2013 at 5:24 PM, Kirill A. Shutemov > <kirill.shutemov@linux.intel.com> wrote: > > @@ -443,6 +443,7 @@ int add_to_page_cache_locked(struct page *page, struct address_space *mapping, > > pgoff_t offset, gfp_t gfp_mask) > > { > > int error; > > + int nr = 1; > > > > VM_BUG_ON(!PageLocked(page)); > > VM_BUG_ON(PageSwapBacked(page)); > > @@ -450,31 +451,61 @@ int add_to_page_cache_locked(struct page *page, struct address_space *mapping, > > error = mem_cgroup_cache_charge(page, current->mm, > > gfp_mask & GFP_RECLAIM_MASK); > > if (error) > > - goto out; > > + return error; > > Due to PageCompound check, thp could not be charged effectively. > Any change added for charging it?
I've missed this. Will fix.
-- Kirill A. Shutemov
| |