Messages in this thread |  | | From | "Rafael J. Wysocki" <> | Subject | Re: [PATCH 4/4] ACPI / platform: Use struct acpi_scan_handler for creating devices | Date | Tue, 29 Jan 2013 13:01:38 +0100 |
| |
On Tuesday, January 29, 2013 09:35:32 AM Mika Westerberg wrote: > On Mon, Jan 28, 2013 at 02:01:14PM +0100, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > > > > Currently, the ACPI namespace scanning code creates platform device > > objects for ACPI device nodes whose IDs match the contents of the > > acpi_platform_device_ids[] table. However, this adds a superfluous > > special case into acpi_bus_device_attach() and makes it more > > difficult to follow than it has to be. It also will make it more > > difficult to implement removal code for those platform device objects > > in the future. > > > > For the above reasons, introduce a struct acpi_scan_handler object > > for creating platform devices and move the code related to that from > > acpi_bus_device_attach() to the .attach() callback of that object. > > Also move the acpi_platform_device_ids[] table to acpi_platform.c. > > > > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > > I've tested this with Haswell machine and once you fix the problem pointed > out by Yasuaki Ishimat (returning always when ACPI_PLATFORM_CLK is set)
Well, yeah. Fixed now.
> the platform device creation works well. This is a nice cleanup and localizes > the hard coded platform device table in one file making maintenance bit > easier. > > Feel free to add: > > Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com> > Tested-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Thanks!
-- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.
|  |