Messages in this thread | | | Date | Tue, 29 Jan 2013 20:45:52 +0900 | From | Masami Hiramatsu <> | Subject | Re: [PATCH 3/5] kprobes: constify check_kprobe_address_safe and friends |
| |
(2013/01/25 13:09), Sasha Levin wrote: > As to arch_check_optimized_kprobe() and check_kprobe_address_safe(), this > is simply way too confusing. It doesn't make sense that a function named > check_[...]() would modify any of it's parameters. > > For example, that entire block within KPROBES_CAN_USE_FTRACE should be split > out and go into update_kprobe_for_ftrace() or something similar. > > If that makes sense, I can send a patch to split out all the parts that > modify anything in those two functions out of them.
I see, that makes sense :-)
Thank you,
-- Masami HIRAMATSU IT Management Research Dept. Linux Technology Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: masami.hiramatsu.pt@hitachi.com
| |