Messages in this thread Patch in this message | | | From | Thomas Jarosch <> | Subject | [perf PATCH] Fix NULL pointer dereference on error | Date | Mon, 28 Jan 2013 09:56:49 +0100 |
| |
pclose(NULL) is undefined behavior and crashes.
Signed-off-by: Thomas Jarosch <thomas.jarosch@intra2net.com> --- tools/perf/util/sort.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c index a83ded2..8333661 100644 --- a/tools/perf/util/sort.c +++ b/tools/perf/util/sort.c @@ -279,10 +279,12 @@ static int hist_entry__srcline_snprintf(struct hist_entry *self, char *bf, *nl = '\0'; path = self->srcline; out_path: - pclose(fp); + if (fp) + pclose(fp); return repsep_snprintf(bf, size, "%s", path); out_ip: - pclose(fp); + if (fp) + pclose(fp); return repsep_snprintf(bf, size, "%-#*llx", BITS_PER_LONG / 4, self->ip); } -- 1.7.11.7
| |