Messages in this thread | | | Date | Tue, 29 Jan 2013 03:05:32 +0100 | From | Andreas Mohr <> | Subject | Re: [RFC PATCH 1/3] PM: Introduce suspend state PM_SUSPEND_FREEZE |
| |
Hi,
first, thanks a lot for advancing PM infrastructure!
> #define PM_SUSPEND_ON ((__force suspend_state_t) 0) > -#define PM_SUSPEND_STANDBY ((__force suspend_state_t) 1) > +#define PM_SUSPEND_FREEZE ((__force suspend_state_t) 1) > +#define PM_SUSPEND_STANDBY ((__force suspend_state_t) 2) > #define PM_SUSPEND_MEM ((__force suspend_state_t) 3) > +#define PM_SUSPEND_MIN PM_SUSPEND_FREEZE > #define PM_SUSPEND_MAX ((__force suspend_state_t) 4)
I'll just pretend to be hopeful that you managed to hunt down all relevant code sites (possibly even splattered around drivers?) which may have made illegally hard-coded assumptions about the number of PM_SUSPEND state "enum"s ;) (e.g. comparisons - such as "==", "<=" etc. - come into mind)
Review of your patch was all fine, nothing to object about.
Thanks,
Andreas Mohr
| |