lkml.org 
[lkml]   [2013]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [GIT PULL] cputime: Full dynticks task/cputime accounting v7
From
2013/1/29 Steven Rostedt <rostedt@goodmis.org>:
> On Mon, 2013-01-28 at 20:03 +0100, Frederic Weisbecker wrote:
>> Ingo,
>>
>> Please pull the new full dynticks cputime accounting code that
>> can be found at:
>>
>> git://git.kernel.org/pub/scm/linux/kernel/git/frederic/linux-dynticks.git
>> tags/full-dynticks-cputime-for-mingo
>>
>> My last concern is the dependency on CONFIG_64BIT. We rely on cputime_t
>> being u64 for reasonable nanosec granularity implementation. And therefore
>> we need a single instruction fetch to read kernel cpustat for atomicity
>> requirement against concurrent incrementation, which only 64 bit archs
>> can provide.
>>
>> It's probably no big deal to solve this issue. What we need is simply some
>> atomic accessors.
>>
>> There is just no emergency though as this new option depends on the context
>> tracking subsystem that only x86-64 (and soon ppc64) implements yet. And
>> this set is complex enough already. I think we can deal with that later.
>
> I've ran these through some basic tests and I don't see any issues. But
> why did you drop the 'comment' patch that you had in v6?

Because it's coming through paulmck's tree already.

>
> Acked-by: Steven Rostedt <rostedt@goodmis.org>

Thanks a lot!


\
 
 \ /
  Last update: 2013-01-29 03:21    [W:0.713 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site