lkml.org 
[lkml]   [2013]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 6/11] ksm: remove old stable nodes more thoroughly
    On Fri, 25 Jan 2013 18:01:59 -0800 (PST)
    Hugh Dickins <hughd@google.com> wrote:

    > +static int remove_all_stable_nodes(void)
    > +{
    > + struct stable_node *stable_node;
    > + int nid;
    > + int err = 0;
    > +
    > + for (nid = 0; nid < nr_node_ids; nid++) {
    > + while (root_stable_tree[nid].rb_node) {
    > + stable_node = rb_entry(root_stable_tree[nid].rb_node,
    > + struct stable_node, node);
    > + if (remove_stable_node(stable_node)) {
    > + err = -EBUSY;

    It's a bit rude to overwrite remove_stable_node()'s return value.

    > + break; /* proceed to next nid */
    > + }
    > + cond_resched();

    Why is this here?

    > + }
    > + }
    > + return err;
    > +}



    \
     
     \ /
      Last update: 2013-01-29 01:21    [W:2.291 / U:0.192 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site