Messages in this thread | | | Date | Mon, 28 Jan 2013 23:08:10 +0100 | From | Andi Kleen <> | Subject | Re: [PATCH 05/12] perf, x86: Support Haswell v4 LBR format |
| |
> > - if (lbr_format == LBR_FORMAT_EIP_FLAGS) { > > + if (lbr_format == LBR_FORMAT_EIP_FLAGS || > > + lbr_format == LBR_FORMAT_EIP_FLAGS2) { > > mis = !!(from & LBR_FROM_FLAG_MISPRED); > > pred = !mis; > > - from = (u64)((((s64)from) << 1) >> 1); > > + if (lbr_format == LBR_FORMAT_EIP_FLAGS) > > + from = (u64)((((s64)from) << 1) >> 1); > > + else if (lbr_format == LBR_FORMAT_EIP_FLAGS2) { > > + intx = !!(from & LBR_FROM_FLAG_INTX); > > + abort = !!(from & LBR_FROM_FLAG_ABORT); > > + from = (u64)((((s64)from) << 3) >> 3); > > + } > > } > > > Wouldn't all that be more readable with a switch-case, especially given > that lbr_format could be extended.
The current version works for me.
-Andi
| |