Messages in this thread | | | Date | Mon, 28 Jan 2013 14:00:46 -0800 | Subject | Re: [RFC PATCH v5 4/8] ACPI, PCI: avoid building pci_slot as module | From | Yinghai Lu <> |
| |
On Mon, Jan 28, 2013 at 1:52 PM, Bjorn Helgaas <bhelgaas@google.com> wrote: > On Mon, Jan 28, 2013 at 2:29 PM, Yinghai Lu <yinghai@kernel.org> wrote: ... >> If bios have messed up slot name or idx, we will get strange 1-1.... >> other crazy name. >> >> if you really need to put it as built-in, may need to some command >> line that user could switch it off. > > It would save us all a lot of time if you gave an example and worked > through the scenario where this is a problem. > > We already have the choice of having pci_slot built-in, so if there's > a bug in that config, we already have the bug. This patch merely > removes a config where the bug might be covered up.
for distribution, current it is with module, so user could blacklist in module.conf
Now with built-in or not, distribution will have it built-in, and user have no chance to disable it.
> I don't know why "adding a command line switch" appeals to you as the > solution to every problem. As far as I'm concerned that's not a > solution to ANY problem. It might be a band-aid to enable users to > limp along while we figure out a correct solution, but it's certainly > not a resolution.
Looks like you want to remove command line support, right ?
Yinghai
| |