lkml.org 
[lkml]   [2013]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/8] perf tools: Add '.' as part of the event 'name' token
From
On Mon, Jan 28, 2013 at 9:52 PM, Stephane Eranian <eranian@google.com> wrote:
> Jiri,
>
> I don't see part 0/8 of this series. Did you send it to me too?
>
> I have some comments about it. I don't see why create something from scratch
> when I have been developing a library (libpfm4) that takes care of that and that
> is already used by many tool developers. That library can be linked with perf
> and provide full symbolic events + all the modifiers. The library is portable
> and supports all existing archs. It can also be used by self-monitoring apps.
>
>
> You're introducing yet another event table to maintain. And believe me this is
> a lot of work to maintain this.
>
> I don't understand why not use this existing library.
>
I meant to add that I think it would be more productive if we (you and I) were
to work on the library to extend it with external text-based event tables that
could be used by perf either directly or thru the libpfm4 interface.


>
> On Sat, Jan 26, 2013 at 9:04 PM, Jiri Olsa <jolsa@redhat.com> wrote:
>> Adding '.' to be recognized as valid part of the event 'name'
>> token. Upcoming non architectural events use '.' as part
>> of the name.
>>
>> Signed-off-by: Jiri Olsa <jolsa@redhat.com>
>> Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
>> Cc: Frederic Weisbecker <fweisbec@gmail.com>
>> Cc: Ingo Molnar <mingo@elte.hu>
>> Cc: Namhyung Kim <namhyung@kernel.org>
>> Cc: Paul Mackerras <paulus@samba.org>
>> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
>> Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
>> Cc: Andi Kleen <ak@linux.intel.com>
>> Cc: Stephane Eranian <eranian@google.com>
>> ---
>> tools/perf/util/parse-events.l | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/tools/perf/util/parse-events.l b/tools/perf/util/parse-events.l
>> index 32a9000..4220093 100644
>> --- a/tools/perf/util/parse-events.l
>> +++ b/tools/perf/util/parse-events.l
>> @@ -80,8 +80,8 @@ event [^,{}/]+
>> num_dec [0-9]+
>> num_hex 0x[a-fA-F0-9]+
>> num_raw_hex [a-fA-F0-9]+
>> -name [a-zA-Z_*?][a-zA-Z0-9_*?]*
>> -name_minus [a-zA-Z_*?][a-zA-Z0-9\-_*?]*
>> +name [a-zA-Z_*?][a-zA-Z0-9_*?\.]*
>> +name_minus [a-zA-Z_*?][a-zA-Z0-9\-_*?\.]*
>> modifier_event [ukhpGH]+
>> modifier_bp [rwx]{1,3}
>>
>> --
>> 1.7.11.7
>>


\
 
 \ /
  Last update: 2013-01-28 23:21    [W:0.115 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site