lkml.org 
[lkml]   [2013]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 23/32] Generic dynamic per cpu refcounting
On Mon, 28 Jan 2013, Kent Overstreet wrote:

> > It goes down to how we allocate page tables. percpu depends on
> > vmalloc space allocation which in turn depends on page table
> > allocation which unfortunately assumes GFP_KERNEL and is spread all
> > across different architectures. Adding @gfp to it came up a couple
> > times but the cases weren't strong enough to push it all the way
> > through. There are some aspects that I like about forcing GFP_KERNEL
> > on all percpu allocations but if there are strong enough cases and
> > someone is willing enough to push it through, maybe.
>
> Ahh, thanks for explaining, was curious about that.

I think its good not to allocate percpu memory in hot paths. Otherwise the
percpu allocator would become much more complex due to locking constraints
of all those hot paths (tried that in the slab allocators once which
ended up in a multi year issue with locking). It is usually possible to
allocate the percpu areas when the struct they belong to is allocated.


\
 
 \ /
  Last update: 2013-01-28 20:41    [W:2.058 / U:0.564 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site