lkml.org 
[lkml]   [2013]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v3 02/71] ARC: Build system: Makefiles, Kconfig, Linker script
    On Mon, Jan 28, 2013 at 11:59:36AM +0530, Vineet Gupta wrote:
    > Hi Sam,
    >
    > On Thursday 24 January 2013 04:20 PM, Vineet Gupta wrote:
    > > Arnd in his review pointed out that arch Kconfig organisation has several
    > > deficiencies:
    > >
    > > * Build time entries for things which can be runtime extracted from DT
    > > (e.g. SDRAM size, core clk frequency..)
    > > * Not multi-platform-image-build friendly (choice .. endchoice constructs)
    > > * cpu variants support (750/770) is exclusive.
    > >
    > > The first 2 have been fixed in subsequent patches.
    > > Due to the nature of the 750 and 770, it is not possible to build for
    > > both together, w/o special runtime glue code which would hurt
    > > performance.
    > >
    > > Signed-off-by: Vineet Gupta <vgupta@synopsys.com>
    > > Cc: Arnd Bergmann <arnd@arndb.de>
    > > Cc: Sam Ravnborg <sam@ravnborg.org>

    Looks good - all former comments addressed, and nothing were jumping
    into my eyes now.
    Many existing architectures looks worse from the build stuff perspective...

    Acked-by: Sam Ravnborg <sam@ravnborg.org>

    Sam


    \
     
     \ /
      Last update: 2013-01-28 20:21    [W:2.865 / U:0.848 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site