lkml.org 
[lkml]   [2013]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 23/32] Generic dynamic per cpu refcounting
On Fri, Jan 25, 2013 at 04:45:10PM +1030, Rusty Russell wrote:
> Tejun Heo <tj@kernel.org> writes:
> >> It also implements two stage shutdown, as we need it to tear down the
> >> percpu counts. Before dropping the initial refcount, you must call
> >> percpu_ref_kill(); this puts the refcount in "shutting down mode" and
> >> switches back to a single atomic refcount with the appropriate barriers
> >> (synchronize_rcu()).
> >
> > Maybe if we have tryget() which only succeeds if the counter is alive,
> > we can replace moulde refcnt with this? Rusty?
>
> Yes, it's similar (hence my previous interest), though module count is a
> bit weird.

I'll try and take a stab at converting it, if I can find time.

> Like Tejun, I'd prefer to see it always alloc up-front, because it
> avoids the _noalloc variant (which is backwards: please hand gfp_t, so
> you don't hide the alloc) and heuristics.

Problem with gfp_t is alloc_percpu() doesn't take it. I don't know why,
but this all goes away with Tejun's idea for allocating from a pool
refilled by workqueue.


\
 
 \ /
  Last update: 2013-01-28 19:41    [W:0.135 / U:0.392 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site