Messages in this thread | | | Date | Mon, 28 Jan 2013 18:41:39 +0400 | From | Lord Glauber Costa of Sealand <> | Subject | Re: [PATCH review 2/6] userns: Allow any uid or gid mappings that don't overlap. |
| |
Hello Mr. Someone.
On 01/28/2013 06:28 PM, Aristeu Rozanski wrote: > On Fri, Jan 25, 2013 at 06:21:00PM -0800, Eric W. Biederman wrote: >> When I initially wrote the code for /proc/<pid>/uid_map. I was lazy >> and avoided duplicate mappings by the simple expedient of ensuring the >> first number in a new extent was greater than any number in the >> previous extent. >> >> Unfortunately that precludes a number of valid mappings, and someone >> noticed and complained. So use a simple check to ensure that ranges >> in the mapping extents don't overlap. > > Acked-by: Someone <aris@redhat.com> >
Documentation/SubmittingPatches:
"then you just add a line saying
Signed-off-by: Random J Developer <random@developer.example.org>
using your real name (sorry, no pseudonyms or anonymous contributions.)"
I know how it feels, but that is how it goes. You'll have to change that.
| |