lkml.org 
[lkml]   [2013]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 04/12] perf, x86: Support the TSX intx/intx_cp qualifiers v2

* Andi Kleen <andi@firstfloor.org> wrote:

> [dropping linux-kernel]

(Re-added, because this concerns others as well.)

> > So please re-send a truly minimal hw-enabling series first,
> > as requested - a minimal series that enables most of the
> > everyday usecases.
>
> I don't have much interesting in arguing what is fundamental
> and what is not. Variants of this patchkit have been used for
> over a year to do Haswell work, and I have a reasonably large
> user base for it both internal in Intel and with some other
> Haswell users.
>
> They need all these features. [...]

That argument is silly, dishonest and misleading: the majority
of perf users don't *ever* specify a different profiling event
from the default 'cycles' one, let alone do they specify CPU
specific features - full stop.

They are using 'perf record/report', 'perf top', or use other
tools like SysProf (that use perf 'cycles' events internally by
default) and that's it.

A select few know about 'cycles:pp', perhaps. (In fact we'll
make that the default in the future, to make profiling even
easier by default.) Some do -g call-graph profiling.

Most developers that use profiling tools want to know where the
silliest overhead in their app is and they don't care much about
CPU specific events.

That group of users includes most kernel developers in fact:
I've rarely seen people go beyond perf record / perf top - and
that's *good* in a sense, because it means they get what they
want from our primary source of profiling information already.

Things like cachemiss profiling or multi-event profiling are a
distant second in terms of popularity. The use of CPU specific
events is even rarer.

Any Haswell-specific features are a second or third order
concern, at best, in terms of installed base. We *do* care about
those usecases as well, but you are wasting precious
hw-enablement time by insisting on more complex patches while
stonewalling my request for the simplest ones - the minimal
patches really belong upstream.

So please send a minimal series that serves the overwhelmingly
common case, without any other distractions, and after that we
can argue Haswell specific extensions to profiling.

This isn't such a difficult or in any way controversial concept
really...

Thanks,

Ingo


\
 
 \ /
  Last update: 2013-01-28 12:21    [W:0.136 / U:0.184 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site