lkml.org 
[lkml]   [2013]   [Jan]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] checkpatch.pl: Fix warnings on code comments
From
Date
On Sun, 2013-01-27 at 18:59 -0500, David Miller wrote:
> From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> Date: Sun, 27 Jan 2013 03:35:39 -0800
>
> > Produces warnings on code comments which follow the Linux coding style
> > guide. While the desired code comment style for networking my differ
> > from the rest of the kernel, both styles should be permitted.
>
> I was actually going to mention to you guys that I've been lackadasical
> about enforcing the comment style I want with the Intel drivers.
>
> That was a mistake, I should have enforced it strictly, as I do for
> the other drivers and the core networking code, from the beginning.
>
> And it's clearly a mistake if you feel the need to take out the very
> checkpatch working that's meant to enforce this comment style in all
> of the networking drivers and core.
>
> Do not revert this, follow it's advice instead.

Ok, I am fine with that. I just had not seen any emails/responses that
this was direction you wanted to go.

So will you be fine with cleanup patches which go through and convert
all the existing code comments to the desired format? If so, I will get
started on patches to cleanup,convert the Intel drivers to the desired
code comment style.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2013-01-28 04:21    [W:0.108 / U:0.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site