lkml.org 
[lkml]   [2013]   [Jan]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH V8 00/13] MIPS: Add Loongson-3 based machines support
From
Hi, John,

Compiling fails because __dev* prefix should be removed
due to upstream changes.

You said that patch 3 need to be rework, but I don't know
how to improve... Could you please tell me where is unsane?

Maybe you means I should make cpu_has_coherent_cache a
runtime value rather than a config option as follows?

1, remove CONFIG_CPU_SUPPORTS_COHERENT_CACHE
2, in arch/mips/include/asm/mach-loongson/cpu-feature-overrides.h
#define cpu_has_coherent_cache 1
3, in arch/mips/include/asm/cpu.h
#define MIPS_CPU_COHERENT_CACHE 0x00080000
4, in arch/mips/include/asm/cpu-features.h
#ifndef cpu_has_coherent_cache
#define cpu_has_coherent_cache (cpu_data[0].options &
MIPS_CPU_INCLUSIVE_CACHES)
#endif

Besides, the SMP code has a bug to fix (IPI sending) and
patch 3, patch 6 need to update. So I think a V9 is needed :(



> On 25/01/13 01:15, 陈华才 wrote:
>> ok, I'll prepare v9 of this seris in these days.
>>>
>
>
> Please dont send v9
>
> read my mail and compile / runtime test the tree please
>
> only patch 3 needs to be reworked and an update for the "MIPS: Loongson
> 3: Add HT-linked PCI support." needs to e made
>
> John
>
>>>>
>>>> Huacai Chen(13):
>>>> MIPS: Loongson: Add basic Loongson-3 definition.
>>>> MIPS: Loongson: Add basic Loongson-3 CPU support.
>>>> MIPS: Loongson: Introduce and use cpu_has_coherent_cache feature.
>>>> MIPS: Loongson 3: Add Lemote-3A machtypes definition.
>>>> MIPS: Loongson: Add UEFI-like firmware interface support.
>>>> MIPS: Loongson 3: Add HT-linked PCI support.
>>>> MIPS: Loongson 3: Add IRQ init and dispatch support.
>>>> MIPS: Loongson 3: Add serial port support.
>>>> MIPS: Loongson: Add swiotlb to support big memory (>4GB).
>>>> MIPS: Loongson: Add Loongson-3 Kconfig options.
>>>> MIPS: Loongson 3: Add Loongson-3 SMP support.
>>>> MIPS: Loongson 3: Add CPU hotplug support.
>>>> MIPS: Loongson: Add a Loongson-3 default config file.
>>>>
>>>> Signed-off-by: Huacai Chen<chenhc@lemote.com>
>>>> Signed-off-by: Hongliang Tao<taohl@lemote.com>
>>>> Signed-off-by: Hua Yan<yanh@lemote.com>
>>>> ---
>>>
>>> Hi,
>>>
>>> I have added all patches apart from 3/13 to my queue.
>>>
>>> I believe "MIPS: Loongson: Introduce and use cpu_has_coherent_cache
>>> feature." should e rewritten in a saner way.
>>>
>>> Please compile and runtime test the tree before I send it to Ralf
>>> -->
>>> http://git.linux-mips.org/?p=john/linux-john.git;a=shortlog;h=refs/heads/mips-next-3.9
>>>
>>> I cleaned up a few minor whitespace errors while merging.
>>>
>>> http://patchwork.linux-mips.org/patch/4547/ has a few comments. Please
>>> prepare a patch asap to address those so i can fold it into the series.
>>>
>>> John
>>>
>>
>>
>
>


--
江苏中科梦兰电子科技有限公司

软件部 陈华才

E-mail: chenhc@lemote.com

Web: http://www.lemote.com/

Add: 江苏省常熟市虞山镇梦兰工业园

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2013-01-27 07:21    [W:0.062 / U:1.312 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site