lkml.org 
[lkml]   [2013]   [Jan]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 23/26] mfd: ab8500-pwm: Enable support for AB8505 PWMLED blink
    Hi Lee,

    On Tue, Jan 15, 2013 at 12:56:03PM +0000, Lee Jones wrote:
    > From: Naga Radhesh <naga.radheshy@stericsson.com>
    >
    > Enable support for PWM OUT LED blinking for AB8505. Instead of
    > having 3 pwm instances from ab8500 core file add it as platform data.
    >
    > Signed-off-by: Lee Jones <lee.jones@linaro.org>
    > Signed-off-by: Naga Radhesh <naga.radheshy@stericsson.com>
    > Reviewed-by: Arun MURTHY <arun.murthy@stericsson.com>
    > Reviewed-by: Srinidhi KASAGAR <srinidhi.kasagar@stericsson.com>
    > ---
    > drivers/mfd/ab8500-core.c | 10 --
    > drivers/misc/ab8500-pwm.c | 282 ++++++++++++++++++++++++++++++++++++
    > include/linux/mfd/ab8500/pwmleds.h | 20 +++
    > include/linux/mfd/abx500/ab8500.h | 2 +
    > 4 files changed, 304 insertions(+), 10 deletions(-)
    > create mode 100644 drivers/misc/ab8500-pwm.c
    This pretty much looks like the already existing and PWM API compliant
    drivers/pwm/ab8500-pwm.c. What's the point here ?

    Cheers,
    Samuel.

    --
    Intel Open Source Technology Centre
    http://oss.intel.com/


    \
     
     \ /
      Last update: 2013-01-28 01:41    [W:4.023 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site