lkml.org 
[lkml]   [2013]   [Jan]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] checkpatch.pl: Fix warnings on (networking specific) code comments
From
Date
On Sun, 2013-01-27 at 03:35 -0800, Jeff Kirsher wrote:
> This patch reverts a portion of the commit to allow multi-line code
> comments to use either style.
[]
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -1878,13 +1878,6 @@ sub process {
> }
>
> if ($realfile =~ m@^(drivers/net/|net/)@ &&
> - $rawline =~ /^\+[ \t]*\/\*[ \t]*$/ &&
> - $prevrawline =~ /^\+[ \t]*$/) {
> - WARN("NETWORKING_BLOCK_COMMENT_STYLE",
> - "networking block comments don't use an empty /* line, use /* Comment...\n" . $hereprev);
> - }
> -
> - if ($realfile =~ m@^(drivers/net/|net/)@ &&
> $rawline !~ m@^\+[ \t]*\*/[ \t]*$@ && #trailing */
> $rawline !~ m@^\+.*/\*.*\*/[ \t]*$@ && #inline /*...*/
> $rawline !~ m@^\+.*\*{2,}/[ \t]*$@ && #trailing **/

Shrug.

Ignore things you don't agree with.

David has written many, many emails
requesting changes for this specific
comment style.

I think you and Intel should use
--ignore=NETWORKING_BLOCK_COMMENT_STYLE
to avoid seeing this if you don't agree
with it.

I also think expectations that everyone
will agree with every checkpatch bleat
are unrealistic.





\
 
 \ /
  Last update: 2013-01-27 19:01    [W:0.575 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site