lkml.org 
[lkml]   [2013]   [Jan]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH]cputime: make bool type for steal ticks
From
2013/1/26 Joe Perches <joe@perches.com>:
> On Sat, 2013-01-26 at 01:45 +0100, Frederic Weisbecker wrote:
>> > diff --git a/kernel/sched/cputime.c b/kernel/sched/cputime.c
> []
>> > @@ -282,7 +282,7 @@ static __always_inline bool steal_account_process_tick(void)
> []
>> > - return st;
>> > + return !!st;
>>
>> I would expect gcc to perform the semantic "!!" cast implicitly. I
>> just did some basic tests locally and it does.
>> I prefer to be paranoid and not do any assumption though, unless I'm
>> told gcc always guarantees this correct implicit cast. I'm queuing
>> this patch and will send it to Ingo.
>
> It's unnecessary.
>
> 6.3.1.2p1:
>
> "When any scalar value is converted to _Bool, the result is 0
> if the value compares equal to 0; otherwise, the result is 1."

Ok then I'll ignore this patch. If somebody oppose, raise your hand.

Thanks.


\
 
 \ /
  Last update: 2013-01-26 16:21    [W:0.045 / U:0.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site