lkml.org 
[lkml]   [2013]   [Jan]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 4/4] cpufreq, highbank: add support for highbank cpufreq
    Date
    On Saturday, January 26, 2013 10:39:53 PM Shawn Guo wrote:
    > Mark,
    >
    > On Fri, Jan 25, 2013 at 01:46:45PM -0600, Mark Langsdorf wrote:
    > > +static int hb_cpufreq_driver_init(void)
    > > +{
    > > + struct device *cpu_dev;
    > > + struct clk *cpu_clk;
    > > + struct device_node *np;
    > > + int ret;
    > > +
    > > + for_each_child_of_node(of_find_node_by_path("/cpus"), np)
    > > + if (of_get_property(np, "operating-points", NULL))
    > > + break;
    > > +
    > > + if (!np) {
    > > + pr_err("failed to find highbank cpufreq node\n");
    > > + return -ENOENT;
    > > + }
    > > +
    > ...
    > > +out_put_node:
    > > + of_node_put(np);
    > > + return ret;
    > > +}
    > > +module_init(hb_cpufreq_driver_init);
    >
    > As we are moving to multiplatform build, this init function will run
    > on all other platforms built together with highbank. We should
    > probably eliminate that effect.

    That change can be made on top of the Mark's patches I think, right?

    If so, I'd prefer it that way. The Mark's patches have been in a limbo for
    too long already and that issue doesn't seem to be serious enough to block
    them any longer.

    Thanks,
    Rafael


    --
    I speak only for myself.
    Rafael J. Wysocki, Intel Open Source Technology Center.


    \
     
     \ /
      Last update: 2013-01-26 23:41    [W:4.243 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site