lkml.org 
[lkml]   [2013]   [Jan]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] IRQ CORE: irq_work_queue function return value not used.
From
2012/11/3 anish kumar <anish198519851985@gmail.com>:
> From: anish kumar <anish198519851985@gmail.com>
>
> As no one is using the return value of irq_work_queue function
> it is better to just make it void.
>
> Acked-by: Steven Rostedt <rostedt@goodmis.org>
> Signed-off-by: anish kumar <anish198519851985@gmail.com>
> ---
> kernel/irq_work.c | 5 ++---
> 1 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/kernel/irq_work.c b/kernel/irq_work.c
> index 1588e3b..4829a31 100644
> --- a/kernel/irq_work.c
> +++ b/kernel/irq_work.c
> @@ -79,17 +79,16 @@ static void __irq_work_queue(struct irq_work *work)
> *
> * Can be re-enqueued while the callback is still in progress.
> */
> -bool irq_work_queue(struct irq_work *work)
> +void irq_work_queue(struct irq_work *work)

Please also update the headers in include/linux/irq_work.h accordingly.

Thanks.

> {
> if (!irq_work_claim(work)) {
> /*
> * Already enqueued, can't do!
> */
> - return false;
> + return;
> }
>
> __irq_work_queue(work);
> - return true;
> }
> EXPORT_SYMBOL_GPL(irq_work_queue);
>
> --
> 1.7.1
>


\
 
 \ /
  Last update: 2013-01-26 18:01    [W:0.041 / U:1.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site