Messages in this thread | | | Subject | Re: [patch v1 2/5] regulator: da9055 change irq state to default | From | Ashish Jangam <> | Date | Fri, 25 Jan 2013 13:56:40 +0530 |
| |
On Thu, 2013-01-24 at 00:03 +0800, Mark Brown wrote: > On Mon, Jan 21, 2013 at 02:05:12PM +0530, Ashish Jangam wrote: > > > > What makes you say that there is a dependency here? It's really not at > > > all obvious why a change to the primary IRQ signalling mechanism would > > > affect the internal interrupts of the device. > > > Yes, functionally this dependency should not matter.However, if > > mfd/primary irq state is low and its components are high then it shall > > not look good. Therefore the term dependency was used, probably I should > > have written it in a different manner. > > This logic doesn't follow terribly directly - looking at what you've > posted it in fact seems that the trigger type is irrelevant in the > function drivers? Though it is functionally irrelevant but in the code setting the primary irq to low and functional driver to high may confuse the code reader. However I leave this decision to you.
| |