Messages in this thread | | | Date | Fri, 25 Jan 2013 08:42:42 -0800 | From | Tejun Heo <> | Subject | Re: [PATCH] cgroup: fix cgroup_path() vs rename() race |
| |
On Fri, Jan 25, 2013 at 03:09:59PM +0800, Li Zefan wrote: > rename() will change dentry->d_name. The result of this race can > be worse than seeing partially rewritten name, but we might access > a stale pointer because rename() will re-allocate memory to hold > a longer name. > > Use dentry_path_raw(), and this vfs API will take care of lockings. > > Signed-off-by: Li Zefan <lizefan@huawei.com>
Urgh... why do we even support rename? :(
Applying to cgroup/for-3.8-fixes w/ stable cc'd.
Thanks.
-- tejun
| |