Messages in this thread | | | Date | Fri, 25 Jan 2013 16:36:16 +0100 | From | Andreas Mohr <> | Subject | Re: [PATCH] block/partition/msdos: detect AIX formatted disks even without 55aa |
| |
Hi,
IMHO that patch would better have a small but important one-liner comment (one cannot rely on people always making use of SCM history functionality, thereby this would be at risk of getting reversed accidentally eventually).
E.g.
/* Note order! (some AIX disks, e.g. unbootable kind, have no MSDOS 55aa) */
if (aix_magic_present(state, data)) { . . .
Apart from that: nice compat catch!
HTH,
Andreas Mohr
-- GNU/Linux. It's not the software that's free, it's you.
| |