Messages in this thread | | | Date | Fri, 25 Jan 2013 16:18:34 +0400 | From | Sergei Shtylyov <> | Subject | Re: [PATCH 1/2]linux-usb:Define a new macro for USB storage match rules |
| |
Hello.
On 25-01-2013 6:44, fangxiaozhi 00110321 wrote:
> From: fangxiaozhi <huananhu@huawei.com>
> 1. Define a new macro for USB storage match rules: > matching with Vendor ID and interface descriptors.
> Signed-off-by: fangxiaozhi <huananhu@huawei.com> > -------------------------------------------------------------------- > > diff -uprN linux-3.8-rc4_orig/drivers/usb/storage/usb.c linux-3.8-rc4/drivers/usb/storage/usb.c > --- linux-3.8-rc4_orig/drivers/usb/storage/usb.c 2013-01-22 14:12:42.595238727 +0800 > +++ linux-3.8-rc4/drivers/usb/storage/usb.c 2013-01-22 14:16:01.398250305 +0800 > @@ -120,6 +120,17 @@ MODULE_PARM_DESC(quirks, "supplemental l > .useTransport = use_transport, \ > } > > +#define UNUSUAL_VENDOR_INTF(idVendor, cl, sc, pr, \ > + vendor_name, product_name, use_protocol, use_transport, \ > + init_function, Flags) \ > +{ \ > + .vendorName = vendor_name, \ > + .productName = product_name, \ > + .useProtocol = use_protocol, \ > + .useTransport = use_transport, \ > + .initFunction = init_function, \ > +}
Shouldn't the field initilaizers be indented with tab, not space?
> diff -uprN linux-3.8-rc4_orig/drivers/usb/storage/usual-tables.c linux-3.8-rc4/drivers/usb/storage/usual-tables.c > --- linux-3.8-rc4_orig/drivers/usb/storage/usual-tables.c 2013-01-22 14:12:42.594238726 +0800 > +++ linux-3.8-rc4/drivers/usb/storage/usual-tables.c 2013-01-22 14:16:01.426250199 +0800 > @@ -41,6 +41,19 @@ > #define USUAL_DEV(useProto, useTrans) \ > { USB_INTERFACE_INFO(USB_CLASS_MASS_STORAGE, useProto, useTrans) } > > +/* Define the device is matched with Vendor ID and interface descriptors */ > +#define UNUSUAL_VENDOR_INTF(id_vendor, cl, sc, pr, \ > + vendorName, productName, useProtocol, useTransport, \ > + initFunction, flags) \ > +{ \ > + .match_flags = USB_DEVICE_ID_MATCH_INT_INFO \ > + | USB_DEVICE_ID_MATCH_VENDOR, \ > + .idVendor = (id_vendor), \ > + .bInterfaceClass = (cl), \ > + .bInterfaceSubClass = (sc), \ > + .bInterfaceProtocol = (pr), \ > + .driver_info = (flags) }
Same question. And trailing '}' should be on a separate line.
WBR, Sergei
| |