Messages in this thread Patch in this message | | | Date | Fri, 25 Jan 2013 03:30:35 -0800 | From | tip-bot for Thomas Jarosch <> | Subject | [tip:perf/core] perf tools: Fix possible (unlikely) buffer overflow |
| |
Commit-ID: a65c23420668f7112395abf9c6f22c6450567bf0 Gitweb: http://git.kernel.org/tip/a65c23420668f7112395abf9c6f22c6450567bf0 Author: Thomas Jarosch <thomas.jarosch@intra2net.com> AuthorDate: Tue, 25 Dec 2012 17:23:39 +0100 Committer: Arnaldo Carvalho de Melo <acme@redhat.com> CommitDate: Thu, 24 Jan 2013 16:40:18 -0300
perf tools: Fix possible (unlikely) buffer overflow
cppcheck reported: [tools/perf/util/sysfs.c:50]: (error) Width 4096 given in format string (no. 1) is larger than destination buffer 'sysfs_mountpoint[4096]', use %4095s to prevent overflowing it
-> All other places in the kernel that use STR(PATH_MAX) have a buffer size of PATH_MAX + 1.
Signed-off-by: Thomas Jarosch <thomas.jarosch@intra2net.com> Link: http://lkml.kernel.org/r/50D9D30B.8090002@intra2net.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> --- tools/perf/util/sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/sysfs.c b/tools/perf/util/sysfs.c index 48c6902..f71e9ea 100644 --- a/tools/perf/util/sysfs.c +++ b/tools/perf/util/sysfs.c @@ -8,7 +8,7 @@ static const char * const sysfs_known_mountpoints[] = { }; static int sysfs_found; -char sysfs_mountpoint[PATH_MAX]; +char sysfs_mountpoint[PATH_MAX + 1]; static int sysfs_valid_mountpoint(const char *sysfs) {
| |