Messages in this thread | | | Date | Thu, 24 Jan 2013 11:08:23 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH 2/4] sched: compute runnable load avg in cpu_load and cpu_avg_load_per_task |
| |
* Alex Shi <alex.shi@intel.com> wrote:
> @@ -2539,7 +2539,11 @@ static void __update_cpu_load(struct rq *this_rq, unsigned long this_load, > void update_idle_cpu_load(struct rq *this_rq) > { > unsigned long curr_jiffies = ACCESS_ONCE(jiffies); > +#if defined(CONFIG_SMP) && defined(CONFIG_FAIR_GROUP_SCHED) > + unsigned long load = (unsigned long)this_rq->cfs.runnable_load_avg; > +#else > unsigned long load = this_rq->load.weight; > +#endif
I'd not make it conditional - just calculate runnable_load_avg all the time (even if group scheduling is disabled) and use it consistently. The last thing we want is to bifurcate scheduler balancer behavior even further.
Thanks,
Ingo
| |