lkml.org 
[lkml]   [2013]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/6] cgroup: initialize cgrp->dentry before css_alloc()
Hello, Li.

On Wed, Jan 23, 2013 at 10:34:53AM +0800, Li Zefan wrote:
> Scheduler changes made in patch #2 are preparation for #3 and #4.
>
> - for #3:
>
> After ss->css_alloc(), there's a small window that tg->css.cgroup is NULL.
> With the change, tg won't be seen before ss->css_online(), so the scheduler
> won't see NULL tg->css.cgroup.
>
> - for #4:
>
> If tg is unregistered and removed from global list in css_free(), and if
> we kfree cgroup right after ss->css_free(), the scheduler can access
> invalid tg->css.cgroup, because tg is also protected by RCU.

Can you please incorporate the above into the patch descriptions?

Thanks!

--
tejun


\
 
 \ /
  Last update: 2013-01-23 20:21    [W:0.149 / U:0.268 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site