[lkml]   [2013]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 16/29] perf, tools: Add support for weight v7
On Wed, Jan 23, 2013 at 6:13 PM, Andi Kleen <> wrote:
>> For PEBS-LL and possibly other special cases, it is important to remember
>> that perf report always end up sorting by period (hist_collapse_resort). But
>> for PEBS-LL we want to sort on nr_events * weight. Thus, with your patch,
>> the only way, I found, to achieve this is by passing:
>> add_hist_entry(self, &entry, al, weight, weight);
> Seems like a hack. IMHO it should always sort by all the keys
> i specified with --sort in exactly that order I specified
Well, it does except for the "implicit" column which uses period, see
And that function is hardcoded to only look at period.

As for the hack, I did not put in in my hist__add_mem_entry() but
rather in the caller.
For PEBS-LL, the period is not important. I think it counts the number
of loads/stores
and not just the qualifying ones. For loads, that means it counts all
loads and not just
the ones above the threshold, but I may be wrong.

> I had a similar thing in a really old version of my patches,
> but I gave it up because it was too unintuitive.
Well, but then it does not present a sensible view of the samples when weight is
more important than period.

> -Andi

 \ /
  Last update: 2013-01-23 19:01    [W:0.115 / U:0.300 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site