Messages in this thread | | | Date | Wed, 23 Jan 2013 20:20:25 +0400 | From | Alexey Kuznetsov <> | Subject | Re: [PATCH] [RFC] tcp: add ability to set a timestamp offset (v2) |
| |
Hello!
On Wed, Jan 23, 2013 at 07:01:52PM +0400, Andrey Vagin wrote: > -#define tcp_time_stamp ((__u32)(jiffies)) > +#define tcp_time_stamp(tp) ((__u32)(jiffies) + tp->tsoffset)
This implies that you always have some tp in hands. AFAIK this is not true, so that I am puzzled how you were able to make something compilable with this definition.
At least in tcp_v4_send_ack() you obviously use some invalid tp, there is no socket in hands there. The thing which is called "sk" is dummy.
With container migration I used per-container offset. When you have no container, you have to do something a little bit smarter.
Alexey
| |