Messages in this thread |  | | Date | Wed, 23 Jan 2013 18:13:51 +0100 | From | Andi Kleen <> | Subject | Re: [PATCH 16/29] perf, tools: Add support for weight v7 |
| |
> For PEBS-LL and possibly other special cases, it is important to remember > that perf report always end up sorting by period (hist_collapse_resort). But > for PEBS-LL we want to sort on nr_events * weight. Thus, with your patch, > the only way, I found, to achieve this is by passing: > > add_hist_entry(self, &entry, al, weight, weight);
Seems like a hack. IMHO it should always sort by all the keys i specified with --sort in exactly that order I specified
I had a similar thing in a really old version of my patches, but I gave it up because it was too unintuitive.
-Andi
|  |