lkml.org 
[lkml]   [2013]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/6] mm: Fold page->_last_nid into page->flags where possible
On Tue, Jan 22, 2013 at 02:46:59PM -0800, Andrew Morton wrote:
>
> reset_page_last_nid() is poorly named. page_reset_last_nid() would be
> better, and consistent.
>

Look at this closer, are you sure you want? Why is page_reset_last_nid()
better or more consistent?

The getter functions for page-related fields start with page (page_count,
page_mapcount etc.) but the setters begin with set (set_page_section,
set_page_zone, set_page_links etc.). For mapcount, we also have
reset_page_mapcount() so to me reset_page_last_nid() is already
consistent.

--
Mel Gorman
SUSE Labs


\
 
 \ /
  Last update: 2013-01-23 16:02    [W:0.101 / U:0.572 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site