lkml.org 
[lkml]   [2013]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [ANNOUNCE] 3.8-rc4-nohz3
From
2013/1/23 Sedat Dilek <sedat.dilek@gmail.com>:
> On Wed, Jan 23, 2013 at 1:11 PM, Frederic Weisbecker <fweisbec@gmail.com> wrote:
>> 2013/1/23 Sedat Dilek <sedat.dilek@gmail.com>:
>>> On Wed, Jan 23, 2013 at 12:19 PM, Sedat Dilek <sedat.dilek@gmail.com> wrote:
>>>> Hi Frederic,
>>>>
>>>> I wanted to 3.8-rc4-nohz3 [1] here on my Ubuntu/precise AMD64 system.
>>>>
>>>> Unfortunately, the build breaks like this:
>>>>
>>>> ERROR: "guest_enter" [arch/x86/kvm/kvm.ko] undefined!
>>>> ERROR: "guest_exit" [arch/x86/kvm/kvm.ko] undefined!
>>>>
>>>
>>> Looks like you tested with CONFIG_KVM=y (as module fails!).
>>
>> Yep. looks like I forgot some EXPORT_SYMBOL().
>>
>
> Hmmm, that was my first thought, too, but about...
>
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index c243b81..fff0932 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -5713,7 +5713,7 @@ static int vcpu_enter_guest(struct kvm_vcpu *vcpu)
> if (req_immediate_exit)
> smp_send_reschedule(vcpu->cpu);
>
> - kvm_guest_enter();
> + guest_enter();
>
> if (unlikely(vcpu->arch.switch_db_regs)) {
> set_debugreg(0, 7);

Yeah, guest_enter and guest_exit need an EXPORT_SYMBOL() in
kernel/context_tracking.c such that the module can find these
functions.


\
 
 \ /
  Last update: 2013-01-23 14:01    [W:0.068 / U:0.412 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site