lkml.org 
[lkml]   [2013]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [RFC PATCH v2 linux-next] et131x: Promote staging et131x driver to drivers/net
On 23 January 2013 10:31, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> On Wed, Jan 23, 2013 at 10:10:58AM +0000, Mark Einon wrote:
>> diff --git a/drivers/net/ethernet/agere/Kconfig b/drivers/net/ethernet/agere/Kconfig
>> new file mode 100644
>> index 0000000..6854966
>> --- /dev/null
>> +++ b/drivers/net/ethernet/agere/Kconfig
>> @@ -0,0 +1,32 @@
>> +#
>> +# Agere device configuration
>> +#
>> +
>> +config NET_VENDOR_AGERE
>> + bool "Agere devices"
>> + default y
>> + depends on PCI
>> + ---help---
>> + If you have a network (Ethernet) card belonging to this class, say Y
>> + and read the Ethernet-HOWTO, available from
>> + <http://www.tldp.org/docs.html#howto>.
>> +
>> + Note that the answer to this question doesn't directly affect the
>> + kernel: saying N will just cause the configurator to skip all
>> + the questions about Atheros devices. If you say Y, you will be asked
> ^^^^^^^
> Agere?

Well spotted, thanks. I'll fix it asap.

>
>> + for your specific card in the following questions.
>> +
>
> I think you should just leave this block out entirely. It doesn't
> save time for anyone.

It looks to be standard boilerplate for all the net/ethernet drivers
having their own directory. I'm going to leave it in for now.
If that's an issue that needs a change, it would also affect the other
drivers and I think should be tackled as a separate thing.

Cheers,

Mark


\
 
 \ /
  Last update: 2013-01-23 13:21    [W:0.115 / U:0.696 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site