lkml.org 
[lkml]   [2013]   [Jan]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRE: [PATCH v2] usb: phy: moving all PHY API definitions to usb/phy directory
> -----Original Message-----
> From: Roger Quadros [mailto:rogerq@ti.com]
> Sent: Tuesday, January 22, 2013 7:51 PM
> To: Venu Byravarasu
> Cc: balbi@ti.com; gregkh@linuxfoundation.org; linux-usb@vger.kernel.org;
> linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v2] usb: phy: moving all PHY API definitions to usb/phy
> directory
>
> On 01/22/2013 01:01 PM, Venu Byravarasu wrote:
> > As drivers/usb/otg/otg.c contains most of the PHY related APIs
> > which are not OTG specific, moving them to more logical place
> > under driver/usb/phy.
> >
> > Signed-off-by: Venu Byravarasu <vbyravarasu@nvidia.com>
> > ---
> > delta from v1:
> > Missed adding newly created file usb_phy.c with previous patch.
> > hence sending v2, after adding that.
> >
> > drivers/usb/otg/otg.c | 184 ------------------------------
> > drivers/usb/phy/Makefile | 1 +
> > drivers/usb/{otg/otg.c => phy/usb_phy.c} | 45 +-------
> > 3 files changed, 6 insertions(+), 224 deletions(-)
> > copy drivers/usb/{otg/otg.c => phy/usb_phy.c} (82%)
>
> what about updating
> drivers/usb/otg/Makefile and Kconfig?
>
> i.e. remove CONFIG_USB_OTG_UTILS and otg.o there?

Thanks for your comments.
Those files may still be needed, as we're not removing otg.c,
due to remaining only otg function i.e. otg_state_string().

Felipe,
Shall I move otg_state_string() to otg.h and remove otg.c altogether?

>
> --
> cheers,
> -roger
>


\
 
 \ /
  Last update: 2013-01-23 01:42    [W:0.054 / U:0.356 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site