Messages in this thread | | | Date | Tue, 22 Jan 2013 09:30:03 -0700 | From | Stephen Warren <> | Subject | Re: [PATCH 2/3] tegra: pwm-backlight: add tegra pwm-bl driver |
| |
On 01/21/2013 08:24 PM, Alex Courbot wrote: > On Tuesday 22 January 2013 01:46:33 Stephen Warren wrote: >>> arch/arm/boot/dts/tegra20-ventana.dts | 18 +++- >>> arch/arm/configs/tegra_defconfig | 1 + >>> drivers/video/backlight/Kconfig | 7 ++ >>> drivers/video/backlight/pwm_bl.c | 3 + >>> drivers/video/backlight/pwm_bl_tegra.c | 159
>>> +static struct pwm_backlight_subdriver pwm_backlight_ventana_subdriver = { >>> + .name = "pwm-backlight-ventana", >>> + .init = init_ventana, >>> + .exit = exit_ventana, >>> + .notify = notify_ventana, >>> + .notify_after = notify_after_ventana, >>> +}; >> >> It seems like all of that code should be completely generic. > > Sorry, I don't get your point here - could you elaborate?
Nothing there (i.e. in the body of any of those functions) seems remotely specific to Ventana or even Ventana's panel; presumably it would work for any built-in LCD panel?
| |