Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [RFC] making HAVE_SYSCALL_WRAPPERS universal (Re: Issues with "x86, um: switch to generic fork/vfork/clone" commit) | Date | Tue, 22 Jan 2013 15:33:50 +0000 |
| |
On Monday 21 January 2013, Al Viro wrote: > 1) alpha, mips > .weak foo > foo = sys_ni_syscall > 2) itanic, ppc > asmlinkage long x (void) __attribute__((weak,alias("sys_ni_syscall"))) > 3) very common - most of the architectures > .weak foo > .set foo sys_ni_syscall > 3a) blackfin, h8300 - same as (3), except that asm symbols get > underscore prepended. > .weak _foo > .set _foo _sys_ni_syscall
One question here: Is there still a reason why we can't use method 2 on all architectures now? The comment in a lot of architectures says
* What we want is __attribute__((weak,alias("sys_ni_syscall"))) * but it doesn't work on all toolchains, so we just do it by hand
and my guess is that all toolchains we support at this point actually do allow it, and turn it into the appropriate assembler syntax.
Arnd
| |